lang: [cs] Add Czech Translation#1012
Closed
MichalSkoula wants to merge 7 commits intocodeigniter4:developfrom
Closed
lang: [cs] Add Czech Translation#1012MichalSkoula wants to merge 7 commits intocodeigniter4:developfrom
MichalSkoula wants to merge 7 commits intocodeigniter4:developfrom
Conversation
kenjis
requested changes
Feb 2, 2024
Member
There was a problem hiding this comment.
Please don't include [sk] changes in a [cs] PR.
One thing at a time: A pull request should only contain one change. That does not mean only one commit, but one change - however many commits it took.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#branching
This reverts commit b9bfc53.
Contributor
Author
|
Ok I have reverted Slovak translation with a new commit. |
Collaborator
|
Hi, |
Contributor
Author
|
ok done :) |
datamweb
requested changes
Feb 2, 2024
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
datamweb
reviewed
Feb 2, 2024
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
kenjis
approved these changes
Feb 3, 2024
Collaborator
Contributor
Author
|
Should I create a new PR? |
Collaborator
|
How to sign past commits is explained here, but feel free to do so if you're comfortable creating new PRs. |
Contributor
Author
|
Creating a new PR is easier for me. I have done so - #1015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added Czech translation for shield
+ fixed Slovak translation.